Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor components and code style #220

Merged
2 commits merged into from
Feb 28, 2021
Merged

Refactor components and code style #220

2 commits merged into from
Feb 28, 2021

Conversation

ghost
Copy link

@ghost ghost commented Feb 26, 2021 •
edited by ghost
Loading

Brief Summary of Changes

  • Remove redundant package.json files and move components to be in the same folder
  • Update files containing jsx to have a .jsx extension
  • Move functions not using the "this" keyword from components to utils
  • Combine all utils in a single file and remove cloudinaryCoreUtils.js
  • Fix code style
  • Add test:lint to the general test script

What does this PR address?

Refactoring
Adds more tests

@ghost ghost requested review from strausr and patrick-tolosa February 26, 2021 21:24
@ghost ghost merged commit 52a77e3 into master Feb 28, 2021
@ghost ghost deleted the refactor/lint branch February 28, 2021 08:01
@SuperSuperDev SuperSuperDev mentioned this pull request May 24, 2024
Open
@SuperSuperDev SuperSuperDev mentioned this pull request Oct 11, 2024
Open
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@strausr @patrick-tolosa @nirmaoz